Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add missing controller.config.annotation docs #3285

Merged
merged 1 commit into from
Nov 22, 2022

Conversation

coolbry95
Copy link
Contributor

@coolbry95 coolbry95 commented Nov 19, 2022

Proposed changes

This is in the helm chart readme but not in the docs.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Nov 19, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #3285 (b20bd63) into main (71745fb) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3285      +/-   ##
==========================================
- Coverage   52.67%   52.64%   -0.03%     
==========================================
  Files          59       59              
  Lines       16107    16107              
==========================================
- Hits         8484     8480       -4     
- Misses       7341     7343       +2     
- Partials      282      284       +2     
Impacted Files Coverage Δ
internal/k8s/configuration.go 95.39% <0.00%> (-0.37%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@lucacome lucacome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @coolbry95. FYI this doc is hopefully going away soon and replaced with a link to deployments/helm-chart/README.md so we have a single source of truth

@lucacome lucacome merged commit 19ae753 into nginxinc:main Nov 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants