Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comments to requirements.txt #3382

Merged
merged 1 commit into from Jan 5, 2023
Merged

Conversation

lucacome
Copy link
Member

Adds comments on how the file was generated, how to update it if introducing a new dependency and why the dependency is required.

@lucacome lucacome requested a review from a team as a code owner December 20, 2022 19:43
@lucacome lucacome self-assigned this Dec 20, 2022
@github-actions github-actions bot added the tests Pull requests that update tests label Dec 20, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2022

Codecov Report

Merging #3382 (86dad51) into main (09364eb) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 86dad51 differs from pull request most recent head a0dcb0d. Consider uploading reports for the commit a0dcb0d to get more accurate results

@@           Coverage Diff           @@
##             main    #3382   +/-   ##
=======================================
  Coverage   51.56%   51.56%           
=======================================
  Files          60       60           
  Lines       16675    16678    +3     
=======================================
+ Hits         8598     8600    +2     
- Misses       7785     7788    +3     
+ Partials      292      290    -2     
Impacted Files Coverage Δ
...ternal/k8s/appprotect/app_protect_configuration.go 86.16% <0.00%> (-0.58%) ⬇️
cmd/nginx-ingress/flags.go 29.85% <0.00%> (-0.44%) ⬇️
internal/k8s/configuration.go 95.76% <0.00%> (+0.36%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lucacome lucacome merged commit 32a163e into main Jan 5, 2023
@lucacome lucacome deleted the tests/requiremenst-comments branch January 5, 2023 12:24
coolbry95 pushed a commit to coolbry95/kubernetes-ingress that referenced this pull request Jan 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Pull requests that update tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants