fix: update github url for app-protect-waf #3412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciarams87
approved these changes
Jan 9, 2023
haywoodsh
approved these changes
Jan 9, 2023
shaun-nx
pushed a commit
that referenced
this pull request
Jan 10, 2023
shaun-nx
added a commit
that referenced
this pull request
Jan 11, 2023
* add new crd fields and validation functions * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * update template * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update validation for policy.go * Remove unused tests for VirtualServer * Remove TODO comments * Update controller to not create secretRef for JWK policy when using JwksURI field. Python tests added for update. * Add README to jwks example folder * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update CRDs and README * Update jwks_uri location to proxy_pass to an upstream * Prevent Nginx reload fail when JwksUri host can't be resolved * Update template to make unique proxy cache directory * Update README * Remove comments and blank space * Update template to check if JwksUri.JwksHost is empty * Update README to add example of ConfigMap with resolver * Allow user input for uri scheme and remove tests * update unit tests * update unit tests * add web docs for jwksURI feature * update readme * Fixes typo, adds proper title capitalisation Co-authored-by: Alan Dooley <ADubhlaoich@users.noreply.github.com> Signed-off-by: Venktesh Shivam Patel <ve.patel@f5.com> * Update docs, jwksuri readme & example * set proxy_cache_valid to 12h * Updates to example files and README * Revert jwks example yaml files * update readme to include links to docs * Update REAMDE * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix: update github url for app-protect-waf (#3412) * Add spacing * update readme formatting * Code review updates * use validateTime instead of a new function. Signed-off-by: Venktesh Shivam Patel <ve.patel@f5.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: “shaun-nx” <“s.odonovan@f5.com”> Co-authored-by: Venktesh <ve.patel@f5.com> Co-authored-by: Alan Dooley <ADubhlaoich@users.noreply.github.com> Co-authored-by: Jcahilltorre <78599298+Jcahilltorre@users.noreply.github.com> Co-authored-by: Shaun <s.odonovan@f5.com>
coolbry95
pushed a commit
to coolbry95/kubernetes-ingress
that referenced
this pull request
Jan 12, 2023
coolbry95
pushed a commit
to coolbry95/kubernetes-ingress
that referenced
this pull request
Jan 12, 2023
* add new crd fields and validation functions * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * update template * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update validation for policy.go * Remove unused tests for VirtualServer * Remove TODO comments * Update controller to not create secretRef for JWK policy when using JwksURI field. Python tests added for update. * Add README to jwks example folder * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update CRDs and README * Update jwks_uri location to proxy_pass to an upstream * Prevent Nginx reload fail when JwksUri host can't be resolved * Update template to make unique proxy cache directory * Update README * Remove comments and blank space * Update template to check if JwksUri.JwksHost is empty * Update README to add example of ConfigMap with resolver * Allow user input for uri scheme and remove tests * update unit tests * update unit tests * add web docs for jwksURI feature * update readme * Fixes typo, adds proper title capitalisation Co-authored-by: Alan Dooley <ADubhlaoich@users.noreply.github.com> Signed-off-by: Venktesh Shivam Patel <ve.patel@f5.com> * Update docs, jwksuri readme & example * set proxy_cache_valid to 12h * Updates to example files and README * Revert jwks example yaml files * update readme to include links to docs * Update REAMDE * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix: update github url for app-protect-waf (nginxinc#3412) * Add spacing * update readme formatting * Code review updates * use validateTime instead of a new function. Signed-off-by: Venktesh Shivam Patel <ve.patel@f5.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: “shaun-nx” <“s.odonovan@f5.com”> Co-authored-by: Venktesh <ve.patel@f5.com> Co-authored-by: Alan Dooley <ADubhlaoich@users.noreply.github.com> Co-authored-by: Jcahilltorre <78599298+Jcahilltorre@users.noreply.github.com> Co-authored-by: Shaun <s.odonovan@f5.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Update a series of links in the documentation pointing to the App-protect-waf examples in github (folder was renamed)
Fixes https://docs.nginx.com/nginx-ingress-controller/app-protect-waf/configuration/
Checklist
Before creating a PR, run through this checklist and mark each as complete.