Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for the Helm Operator OOM issue #3470

Merged
merged 4 commits into from Jan 24, 2023

Conversation

haywoodsh
Copy link
Contributor

@haywoodsh haywoodsh commented Jan 23, 2023

Proposed changes

Add documentation to advise users to watch single namespace or increase memory limit in case of an OOMkill event

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Jan 23, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jan 23, 2023

Codecov Report

Merging #3470 (15ec556) into main (7c117ec) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 15ec556 differs from pull request most recent head b21a07a. Consider uploading reports for the commit b21a07a to get more accurate results

@@           Coverage Diff           @@
##             main    #3470   +/-   ##
=======================================
  Coverage   51.97%   51.98%           
=======================================
  Files          60       60           
  Lines       16811    16806    -5     
=======================================
- Hits         8737     8736    -1     
+ Misses       7777     7775    -2     
+ Partials      297      295    -2     
Impacted Files Coverage Δ
internal/configs/virtualserver.go 95.05% <0.00%> (-0.02%) ⬇️
pkg/apis/configuration/validation/virtualserver.go 94.38% <0.00%> (-0.01%) ⬇️
internal/configs/version2/http.go 0.00% <0.00%> (ø)
internal/k8s/configuration.go 95.79% <0.00%> (+0.36%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@haywoodsh haywoodsh marked this pull request as ready for review January 23, 2023 18:15
@haywoodsh haywoodsh requested a review from a team as a code owner January 23, 2023 18:15
@haywoodsh haywoodsh merged commit ae2e004 into main Jan 24, 2023
@haywoodsh haywoodsh deleted the docs/add-docs-for-helm-operator-oom branch January 24, 2023 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants