Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix helm values to match chart value #3497

Merged
merged 4 commits into from Feb 2, 2023
Merged

Fix helm values to match chart value #3497

merged 4 commits into from Feb 2, 2023

Conversation

jasonwilliams14
Copy link
Contributor

Proposed changes

Describe the use case and detail of the change. If this PR addresses an issue on GitHub, make sure to include a link to that issue here in this description (not in the title of the PR).

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • [ x] I have read the CONTRIBUTING doc
  • [ x] I have added tests that prove my fix is effective or that my feature works
  • [ x] I have checked that all unit tests pass after adding my changes
  • [ x] I have updated necessary documentation
  • I have rebased my branch onto main
  • [x ] I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@jasonwilliams14 jasonwilliams14 added the documentation Pull requests/issues for documentation label Jan 27, 2023
@github-actions github-actions bot added the helm_chart Pull requests that update the Helm Chart label Jan 27, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jan 27, 2023

Codecov Report

Merging #3497 (5366f35) into main (05e1357) will increase coverage by 0.04%.
The diff coverage is n/a.

❗ Current head 5366f35 differs from pull request most recent head cfbe390. Consider uploading reports for the commit cfbe390 to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #3497      +/-   ##
==========================================
+ Coverage   51.95%   51.99%   +0.04%     
==========================================
  Files          60       60              
  Lines       16797    16811      +14     
==========================================
+ Hits         8727     8741      +14     
  Misses       7775     7775              
  Partials      295      295              
Impacted Files Coverage Δ
pkg/apis/dos/validation/dos.go 94.54% <0.00%> (ø)
internal/configs/version2/http.go 0.00% <0.00%> (ø)
pkg/apis/configuration/validation/policy.go 91.16% <0.00%> (ø)
pkg/apis/configuration/validation/virtualserver.go 94.39% <0.00%> (+<0.01%) ⬆️
internal/configs/virtualserver.go 95.07% <0.00%> (+0.01%) ⬆️
internal/k8s/configuration.go 95.79% <0.00%> (+0.03%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lucacome lucacome marked this pull request as ready for review February 2, 2023 03:30
@lucacome lucacome requested a review from a team as a code owner February 2, 2023 03:30
Signed-off-by: Luca Comellini <luca.com@gmail.com>
@lucacome lucacome merged commit e3ebd6e into main Feb 2, 2023
@lucacome lucacome deleted the docs/helm-doc-update branch February 2, 2023 23:53
@lucacome lucacome removed the helm_chart Pull requests that update the Helm Chart label Feb 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants