Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for jwt jwksuri #3511

Merged
merged 11 commits into from Feb 3, 2023
Merged

Add tests for jwt jwksuri #3511

merged 11 commits into from Feb 3, 2023

Conversation

vepatel
Copy link
Contributor

@vepatel vepatel commented Feb 1, 2023

Proposed changes

  • Add test for jwt jwksuri feature
  • CI changes to fetch Azure AD secret from github
  • minor change in jwks docs

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added the tests Pull requests that update tests label Feb 1, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 1, 2023

Codecov Report

Merging #3511 (6da2077) into main (9198212) will decrease coverage by 0.03%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #3511      +/-   ##
==========================================
- Coverage   52.00%   51.98%   -0.03%     
==========================================
  Files          60       60              
  Lines       16816    16816              
==========================================
- Hits         8746     8742       -4     
- Misses       7775     7777       +2     
- Partials      295      297       +2     
Impacted Files Coverage Δ
internal/k8s/configuration.go 95.43% <0.00%> (-0.37%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@vepatel vepatel marked this pull request as ready for review February 2, 2023 08:46
@vepatel vepatel requested a review from a team as a code owner February 2, 2023 08:46
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Feb 2, 2023
@vepatel vepatel merged commit 44bcbf8 into main Feb 3, 2023
@vepatel vepatel deleted the tests/jwksuri-jwt branch February 3, 2023 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation tests Pull requests that update tests
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

None yet

4 participants