Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make changes to req type and parameters #3528

Merged
merged 3 commits into from Feb 7, 2023
Merged

Conversation

vepatel
Copy link
Contributor

@vepatel vepatel commented Feb 7, 2023

Proposed changes

  • Change request type and parameters for Azure token endpoint

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@vepatel vepatel requested a review from a team as a code owner February 7, 2023 13:06
@github-actions github-actions bot added the tests Pull requests that update tests label Feb 7, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #3528 (9e53fd9) into main (2efa8d4) will increase coverage by 0.02%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #3528      +/-   ##
==========================================
+ Coverage   51.98%   52.00%   +0.02%     
==========================================
  Files          60       60              
  Lines       16816    16816              
==========================================
+ Hits         8742     8746       +4     
+ Misses       7777     7775       -2     
+ Partials      297      295       -2     
Impacted Files Coverage Δ
internal/k8s/configuration.go 95.79% <0.00%> (+0.36%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@vepatel vepatel merged commit e89092b into main Feb 7, 2023
@vepatel vepatel deleted the tests/fix-jwksuri-test branch February 7, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Pull requests that update tests
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

None yet

4 participants