Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial install guide for GCP Marketplace Package #3561

Merged
merged 4 commits into from Feb 21, 2023

Conversation

shaun-nx
Copy link
Contributor

@shaun-nx shaun-nx commented Feb 17, 2023

Proposed changes

This PR adds the initial install guide for installing our image through the GCP Marketplace.

NOTE this document is very likely subject to change. The purpose of this PR is to have something there for the initial listing even if it isn't fully complete. Once the listing is fully public, this document can be revised to include more up-to-date screenshots of our listing as well as details of all available configuration options.

This document will be available at https://docs.nginx.com/nginx-ingress-controller/installation/using-gcp-marketplace-package when this PR is merged.

@shaun-nx shaun-nx requested a review from a team as a code owner February 17, 2023 10:16
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Feb 17, 2023
@codecov-commenter
Copy link

codecov-commenter commented Feb 17, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-3.0@40e3a2b). Click here to learn what that means.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@              Coverage Diff               @@
##             release-3.0    #3561   +/-   ##
==============================================
  Coverage               ?   51.96%           
==============================================
  Files                  ?       60           
  Lines                  ?    16794           
  Branches               ?        0           
==============================================
  Hits                   ?     8727           
  Misses                 ?     7773           
  Partials               ?      294           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Co-authored-by: Alan Dooley <ADubhlaoich@users.noreply.github.com>
Signed-off-by: Venktesh Shivam Patel <ve.patel@f5.com>
@shaun-nx shaun-nx merged commit 00ea0f7 into release-3.0 Feb 21, 2023
@shaun-nx shaun-nx deleted the docs/gcp-install-docs branch February 21, 2023 09:05
lucacome pushed a commit that referenced this pull request Apr 19, 2023
* Initial install guide for GCP Marketplace Package

* Review updates

* Revert page name

* update description

Co-authored-by: Alan Dooley <ADubhlaoich@users.noreply.github.com>
Signed-off-by: Venktesh Shivam Patel <ve.patel@f5.com>

---------

Signed-off-by: Venktesh Shivam Patel <ve.patel@f5.com>
Co-authored-by: Venktesh Shivam Patel <ve.patel@f5.com>
Co-authored-by: Alan Dooley <ADubhlaoich@users.noreply.github.com>
(cherry picked from commit 00ea0f7)
lucacome pushed a commit that referenced this pull request Apr 19, 2023
* Initial install guide for GCP Marketplace Package

* Review updates

* Revert page name

* update description

Co-authored-by: Alan Dooley <ADubhlaoich@users.noreply.github.com>
Signed-off-by: Venktesh Shivam Patel <ve.patel@f5.com>

---------

Signed-off-by: Venktesh Shivam Patel <ve.patel@f5.com>
Co-authored-by: Venktesh Shivam Patel <ve.patel@f5.com>
Co-authored-by: Alan Dooley <ADubhlaoich@users.noreply.github.com>
(cherry picked from commit 00ea0f7)
lucacome added a commit that referenced this pull request Apr 24, 2023
* Initial install guide for GCP Marketplace Package

* Review updates

* Revert page name

* update description

Co-authored-by: Alan Dooley <ADubhlaoich@users.noreply.github.com>
Signed-off-by: Venktesh Shivam Patel <ve.patel@f5.com>

---------

Signed-off-by: Venktesh Shivam Patel <ve.patel@f5.com>
Co-authored-by: Venktesh Shivam Patel <ve.patel@f5.com>
Co-authored-by: Alan Dooley <ADubhlaoich@users.noreply.github.com>
(cherry picked from commit 00ea0f7)

Co-authored-by: Shaun <s.odonovan@f5.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

None yet

7 participants