Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated command with environment file #3576

Merged
merged 2 commits into from Feb 23, 2023
Merged

Replace deprecated command with environment file #3576

merged 2 commits into from Feb 23, 2023

Conversation

jongwooo
Copy link
Contributor

Proposed changes

Resolve #3575

Update .github/workflows/issues.yaml to use environment file instead of deprecated set-output command.
For more information, see: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/

I found the workflow files that use set-output command through the following command:

$ find . -name '*.yml' -o -name '*.yaml' | xargs egrep '\bset-output\b'

AS-IS

echo "::set-output name=text::$text"

TO-BE

echo "text=$text" >> $GITHUB_OUTPUT

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@jongwooo jongwooo requested a review from a team as a code owner February 21, 2023 16:50
@github-actions github-actions bot added the chore Pull requests for routine tasks label Feb 21, 2023
@lucacome lucacome self-assigned this Feb 21, 2023
Copy link
Member

@lucacome lucacome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jongwooo !

@lucacome lucacome added this to the v3.1.0 milestone Feb 23, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #3576 (7079ad9) into main (14ebdc4) will decrease coverage by 0.03%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #3576      +/-   ##
==========================================
- Coverage   52.32%   52.29%   -0.03%     
==========================================
  Files          59       59              
  Lines       16849    16849              
==========================================
- Hits         8816     8812       -4     
- Misses       7738     7740       +2     
- Partials      295      297       +2     
Impacted Files Coverage Δ
internal/k8s/configuration.go 95.43% <0.00%> (-0.37%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lucacome lucacome merged commit 37b1fd0 into nginxinc:main Feb 23, 2023
@jongwooo jongwooo deleted the chore/replace-deprecated-command-with-environment-file branch February 26, 2023 04:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

Replace deprecated set-output command with environment file
4 participants