feat: Fix instruction link for NGINX Ingress Helm Operator #3596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit makes a small change to the the third prerequisite in the installation document to point at the correct instructions it is referencing. It also expands the link itself to make it clearer what precisely the reader is being referenced to, and prefixes F5 to the first instance of the product name (Ignoring the ephemeral note).
github-actions
bot
added
the
documentation
jjngx
approved these changes
Feb 27, 2023
ciarams87
approved these changes
Feb 27, 2023
vepatel
approved these changes
Feb 27, 2023
lucacome
requested changes
Feb 27, 2023
Co-authored-by: Luca Comellini <luca.com@gmail.com> Signed-off-by: Alan Dooley <ADubhlaoich@users.noreply.github.com>
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #3596 +/- ##
=======================================
Coverage 52.23% 52.23%
=======================================
Files 59 59
Lines 16877 16877
=======================================
Hits 8816 8816
Misses 7766 7766
Partials 295 295 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
lucacome
reviewed
Feb 28, 2023
haywoodsh
approved these changes
Mar 9, 2023
lucacome
reviewed
Mar 15, 2023
Co-authored-by: Luca Comellini <luca.com@gmail.com> Signed-off-by: Alan Dooley <ADubhlaoich@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes a small change to the the third prerequisite in the installation document to point at the correct instructions it is referencing.
It also expands the link itself to make it clearer what precisely the reader is being referenced to, and prefixes F5 to the first instance of the product name (Ignoring the ephemeral note).
Proposed changes
Describe the use case and detail of the change. If this PR addresses an issue on GitHub, make sure to include a link to that issue here in this description (not in the title of the PR).
Checklist
Before creating a PR, run through this checklist and mark each as complete.