Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update service-insight.md to fix helm parameter typo #3654

Merged
merged 1 commit into from Mar 16, 2023

Conversation

aknot242
Copy link
Contributor

Addresses #3653

Proposed changes

Describe the use case and detail of the change. If this PR addresses an issue on GitHub, make sure to include a link to that issue here in this description (not in the title of the PR).

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@aknot242 aknot242 requested a review from a team as a code owner March 16, 2023 09:45
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Mar 16, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #3654 (3421552) into main (0770b96) will increase coverage by 0.02%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #3654      +/-   ##
==========================================
+ Coverage   52.21%   52.23%   +0.02%     
==========================================
  Files          59       59              
  Lines       16877    16877              
==========================================
+ Hits         8812     8816       +4     
+ Misses       7768     7766       -2     
+ Partials      297      295       -2     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@ciarams87 ciarams87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @aknot242!

@lucacome lucacome merged commit b7d0dab into nginxinc:main Mar 16, 2023
52 checks passed
@lucacome lucacome linked an issue Mar 17, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

Small typo in Service Insights documentation
4 participants