Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for read-only root filesystem #3661

Merged
merged 9 commits into from Mar 21, 2023

Conversation

vepatel
Copy link
Contributor

@vepatel vepatel commented Mar 17, 2023

Proposed changes

  • Add docs for read-only root filesystem under "Security"

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@vepatel vepatel requested a review from a team as a code owner March 17, 2023 16:42
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Mar 17, 2023
Copy link
Collaborator

@brianehlert brianehlert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

editorial and need better exposure for end comments and note

docs/content/configuration/security.md Outdated Show resolved Hide resolved
docs/content/configuration/security.md Outdated Show resolved Hide resolved
docs/content/configuration/security.md Outdated Show resolved Hide resolved
docs/content/configuration/security.md Outdated Show resolved Hide resolved
docs/content/installation/installation-with-helm.md Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Mar 20, 2023

Codecov Report

Merging #3661 (2202a5b) into main (04fe202) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3661   +/-   ##
=======================================
  Coverage   52.31%   52.31%           
=======================================
  Files          59       59           
  Lines       16853    16853           
=======================================
  Hits         8817     8817           
  Misses       7741     7741           
  Partials      295      295           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tomasohaodha tomasohaodha added this to the v3.1.0 milestone Mar 20, 2023
@vepatel vepatel enabled auto-merge (squash) March 20, 2023 14:40
vepatel and others added 2 commits March 20, 2023 16:36
Co-authored-by: Ciara Stacke <18287516+ciarams87@users.noreply.github.com>
Signed-off-by: Venktesh Shivam Patel <ve.patel@f5.com>
@vepatel vepatel requested a review from ciarams87 March 20, 2023 16:37
Copy link
Member

@ciarams87 ciarams87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏼

@vepatel vepatel merged commit d9f4a7a into main Mar 21, 2023
14 of 17 checks passed
@vepatel vepatel deleted the docs/read-only-file-system branch March 21, 2023 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

None yet

5 participants