Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Add WAF Bundle example (#3656)" #3677

Merged
merged 1 commit into from Mar 21, 2023
Merged

Conversation

jjngx
Copy link
Contributor

@jjngx jjngx commented Mar 21, 2023

This reverts commit b649666.

Proposed changes

Removing references to app protect policy bundles.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@jjngx jjngx requested a review from a team as a code owner March 21, 2023 16:44
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Mar 21, 2023
@jjngx jjngx added this to the v3.1.0 milestone Mar 21, 2023
Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, but if it's of any use, there's a commenting shortcode:

{{< comment >}} This text will not appear anywhere {{< /comment >}}

It means you can hide the content without tearing it out of codebase, presuming there's intent to re-add this at a later point.

@jjngx jjngx merged commit df264ff into main Mar 21, 2023
45 of 52 checks passed
@jjngx jjngx deleted the docs/remove-bundle-docs branch March 21, 2023 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

None yet

3 participants