Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update correct path for default-server-secret #3713

Merged
merged 4 commits into from Apr 4, 2023

Conversation

jasonwilliams14
Copy link
Contributor

Proposed changes

Small update to manifest install, which points to the correct path where the default-server-secret.yaml file is located.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • [ X] I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • [ X] I have updated necessary documentation
  • I have rebased my branch onto main
  • [ x] I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@jasonwilliams14 jasonwilliams14 requested a review from a team as a code owner March 31, 2023 21:08
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Mar 31, 2023
@codecov
Copy link

codecov bot commented Mar 31, 2023

Codecov Report

Merging #3713 (b9a29ff) into main (ad149b2) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3713      +/-   ##
==========================================
- Coverage   52.35%   52.33%   -0.03%     
==========================================
  Files          59       59              
  Lines       16880    16880              
==========================================
- Hits         8838     8834       -4     
- Misses       7747     7749       +2     
- Partials      295      297       +2     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: Jason Williams - NGIИX <jason.williams14@gmail.com>
Signed-off-by: Jason Williams - NGIИX <jason.williams14@gmail.com>
@jasonwilliams14 jasonwilliams14 enabled auto-merge (squash) April 4, 2023 18:37
@jasonwilliams14 jasonwilliams14 merged commit 9d57002 into main Apr 4, 2023
56 checks passed
@jasonwilliams14 jasonwilliams14 deleted the doc/default-secret-update branch April 4, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

None yet

4 participants