Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove semverCompare for allocateLoadBalancerNodePorts #3814

Merged
merged 2 commits into from May 18, 2023

Conversation

centromere
Copy link
Contributor

Kubernetes 1.22.0 is now a minimum requirement for the entire chart.

Proposed changes

Describe the use case and detail of the change. If this PR addresses an issue on GitHub, make sure to include a link to that issue here in this description (not in the title of the PR).

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Kubernetes 1.22.0 is now a minimum requirement for the entire chart.
@centromere centromere requested a review from a team as a code owner April 25, 2023 22:59
@github-actions github-actions bot added the helm_chart Pull requests that update the Helm Chart label Apr 25, 2023
@codecov
Copy link

codecov bot commented Apr 26, 2023

Codecov Report

Merging #3814 (97575b7) into main (aac5073) will decrease coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3814      +/-   ##
==========================================
- Coverage   51.95%   51.91%   -0.04%     
==========================================
  Files          59       59              
  Lines       16742    16742              
==========================================
- Hits         8698     8692       -6     
- Misses       7746     7750       +4     
- Partials      298      300       +2     

see 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lucacome lucacome added the bug An issue reporting a potential bug label May 18, 2023
@lucacome lucacome merged commit 4cba337 into nginxinc:main May 18, 2023
36 of 38 checks passed
@centromere centromere deleted the fix-allocateloadbalancernodeports branch May 18, 2023 19:44
@lucacome lucacome removed the bug An issue reporting a potential bug label Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
helm_chart Pull requests that update the Helm Chart
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

None yet

4 participants