Fix GlobalConfiguration name in Helm Chart #3815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
bug
Codecov Report
@@ Coverage Diff @@
## main #3815 +/- ##
==========================================
+ Coverage 52.37% 52.40% +0.02%
==========================================
Files 59 59
Lines 16898 16898
==========================================
+ Hits 8851 8855 +4
+ Misses 7750 7748 -2
+ Partials 297 295 -2 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
shaun-nx
approved these changes
Apr 26, 2023
ciarams87
approved these changes
Apr 26, 2023
lucacome
added a commit
that referenced
this pull request
May 4, 2023
(cherry picked from commit 45586c0)
lucacome
added a commit
that referenced
this pull request
May 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the name to use
nginx-ingress.controller.fullnameconsistently for GlobalConfiguration.Fixes #3753