Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

indent in annotations key in leader-elec cm #3862

Merged
merged 1 commit into from May 4, 2023

Conversation

vepatel
Copy link
Contributor

@vepatel vepatel commented May 4, 2023

Proposed changes

(cherry picked from commit a4cbe2f)

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@vepatel vepatel requested a review from a team as a code owner May 4, 2023 12:02
@github-actions github-actions bot added bug An issue reporting a potential bug helm_chart Pull requests that update the Helm Chart labels May 4, 2023
@codecov
Copy link

codecov bot commented May 4, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-3.1@643f1b4). Click here to learn what that means.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             release-3.1    #3862   +/-   ##
==============================================
  Coverage               ?   52.38%           
==============================================
  Files                  ?       59           
  Lines                  ?    16890           
  Branches               ?        0           
==============================================
  Hits                   ?     8848           
  Misses                 ?     7747           
  Partials               ?      295           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lucacome lucacome merged commit 301eb19 into release-3.1 May 4, 2023
50 of 53 checks passed
@lucacome lucacome deleted the fix/leader-election-cm-annotations branch May 4, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue reporting a potential bug helm_chart Pull requests that update the Helm Chart
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

None yet

4 participants