Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update expired CRL and Certificates for IngressMTLS python tests #3906

Merged
merged 2 commits into from May 17, 2023

Conversation

shaun-nx
Copy link
Contributor

@shaun-nx shaun-nx commented May 17, 2023

Proposed changes

Adds new client certs, ca certs and CRLs to be used in our python tests.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@shaun-nx shaun-nx requested a review from a team as a code owner May 17, 2023 09:50
@github-actions github-actions bot added the tests Pull requests that update tests label May 17, 2023
@codecov
Copy link

codecov bot commented May 17, 2023

Codecov Report

Merging #3906 (6dd7782) into main (aac5073) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3906      +/-   ##
==========================================
- Coverage   51.95%   51.94%   -0.02%     
==========================================
  Files          59       59              
  Lines       16742    16742              
==========================================
- Hits         8698     8696       -2     
- Misses       7746     7748       +2     
  Partials      298      298              

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@shaun-nx shaun-nx merged commit 21f9d8f into main May 17, 2023
60 checks passed
@shaun-nx shaun-nx deleted the crlCertUpdate branch May 17, 2023 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Pull requests that update tests
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

None yet

3 participants