Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for controller.selectorLabels #3977

Conversation

hanyouqing
Copy link
Contributor

@hanyouqing hanyouqing commented Jun 8, 2023

Proposed changes

Fix issue #3976

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@hanyouqing hanyouqing requested a review from a team as a code owner June 8, 2023 09:25
@github-actions github-actions bot added the helm_chart Pull requests that update the Helm Chart label Jun 8, 2023
@jasonwilliams14
Copy link
Contributor

@hanyouqing Thank you for the PR. We are currently reviewing this on our side and trying to reproduce the issue. If you could respond to our request for additional information in the issue thread you created, that would be great. Thank you.

@hanyouqing
Copy link
Contributor Author

@hanyouqing Thank you for the PR. We are currently reviewing this on our side and trying to reproduce the issue. If you could respond to our request for additional information in the issue thread you created, that would be great. Thank you.

Thanks for your reply! I'm glad to share the reproduce steps, but I can't reproduce it with Helm. We manage the helm chart with Terraform, It might be some issues for the helm Terraform provider. Let me figure it out, if so I'll close the pr.

@hanyouqing
Copy link
Contributor Author

Hi @jasonwilliams14, I've added some comments and how to reproduce it see the issue page #3976 (comment).
Thanks!

@brianehlert brianehlert added bug An issue reporting a potential bug backlog Pull requests/issues that are backlog items labels Jul 7, 2023
@lucacome lucacome changed the title Fix the immutable matchlabels issue when upgrade helm to v3.1.x Add support for controller.selectorLabels Jul 21, 2023
Copy link
Member

@lucacome lucacome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good @hanyouqing

@vepatel vepatel mentioned this pull request Jul 24, 2023
6 tasks
@lucacome lucacome enabled auto-merge (squash) July 25, 2023 23:49
@lucacome lucacome removed the bug An issue reporting a potential bug label Jul 25, 2023
@lucacome lucacome added this to the v3.3.0 milestone Jul 25, 2023
@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Merging #3977 (ddd2611) into main (2f39705) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3977      +/-   ##
==========================================
- Coverage   51.87%   51.84%   -0.03%     
==========================================
  Files          59       59              
  Lines       16710    16710              
==========================================
- Hits         8668     8664       -4     
- Misses       7745     7747       +2     
- Partials      297      299       +2     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@lucacome lucacome merged commit 0a02259 into nginxinc:main Jul 25, 2023
23 checks passed
@hanyouqing hanyouqing mentioned this pull request Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Pull requests/issues that are backlog items helm_chart Pull requests that update the Helm Chart
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

Introduced changes to the immutable MatchLabels to the daemonset in #3606
6 participants