Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make NAP independent from Plus #4054

Merged
merged 1 commit into from Jun 24, 2023
Merged

Make NAP independent from Plus #4054

merged 1 commit into from Jun 24, 2023

Conversation

lucacome
Copy link
Member

Proposed changes

NAP doesn't support debian 12, this creates a separate image using debian 11 instead of using debian-plus as base

@lucacome lucacome requested a review from a team as a code owner June 23, 2023 23:40
@lucacome lucacome self-assigned this Jun 23, 2023
@github-actions github-actions bot added the chore Pull requests for routine tasks label Jun 23, 2023
@github-actions
Copy link

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Manifest Files

@codecov
Copy link

codecov bot commented Jun 23, 2023

Codecov Report

Merging #4054 (c2f2399) into main (807b0aa) will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4054      +/-   ##
==========================================
+ Coverage   51.83%   51.84%   +0.01%     
==========================================
  Files          59       59              
  Lines       16705    16705              
==========================================
+ Hits         8659     8661       +2     
+ Misses       7747     7745       -2     
  Partials      299      299              

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@jasonwilliams14 jasonwilliams14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@lucacome lucacome merged commit 8acd2c5 into main Jun 24, 2023
63 checks passed
@lucacome lucacome deleted the chore/separate-nap-images branch June 24, 2023 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Pull requests for routine tasks
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

None yet

2 participants