Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade nginx-hugo-theme version to support newer Hugo releases #4149

Merged
merged 3 commits into from Aug 1, 2023

Conversation

jputrino
Copy link
Contributor

@jputrino jputrino commented Jul 25, 2023

Proposed changes

This PR updates the nginx-hugo-theme module to v0.34.0, which adds support for Hugo v0.115.3 (and subsequent newer releases). This upgrade is necessary to address security vulnerabilities in the earlier pinned version of Hugo.

  • The docs/README has been updated to match that used across the NGINX projects where we develop docs.
  • The docs/makefile and netlify configs have been updated to include the deploy-preview make command, which is needed to build docs for the deploy-preview and branch contexts in Netlify. These settings are also now in parity with the configurations used across the NGINX documentation projects.

Related PR: nginxinc/nginx-hugo-theme#16

Once this PR is merged, the environment variables that are stored in Netlify for the nginx-hugo-theme version and hugo version will be updated accordingly.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@jputrino jputrino requested a review from a team as a code owner July 25, 2023 19:40
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Jul 25, 2023
@github-actions
Copy link

github-actions bot commented Jul 25, 2023

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Manifest Files

docs/go.mod
  • github.com/nginxinc/nginx-hugo-theme@0.34.0
  • github.com/nginxinc/nginx-hugo-theme@0.33.0

@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Merging #4149 (88aaf1c) into main (8687996) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4149      +/-   ##
==========================================
- Coverage   51.91%   51.89%   -0.03%     
==========================================
  Files          59       59              
  Lines       16735    16735              
==========================================
- Hits         8688     8684       -4     
- Misses       7749     7751       +2     
- Partials      298      300       +2     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

docs/README.md Outdated Show resolved Hide resolved
jputrino and others added 2 commits August 1, 2023 12:24
Hugo releases

- Updates Makefile and netlify configuration file to
make sure the hugo mod command is run for deploy
preview and branch deploy builds

- Adds docs/README with instructions for using hugo

- Updates nginx-hugo-theme module
@lucacome lucacome merged commit 28a0cea into main Aug 1, 2023
61 checks passed
@lucacome lucacome deleted the test-hugo-upgrade branch August 1, 2023 21:51
jputrino added a commit that referenced this pull request Aug 2, 2023
- Updates Makefile and netlify configuration file to
make sure the hugo mod command is run for deploy
preview and branch deploy builds

- Adds docs/README with instructions for using hugo

- Updates nginx-hugo-theme module
lucacome pushed a commit that referenced this pull request Aug 3, 2023
… (#4178)

- Updates Makefile and netlify configuration file to
make sure the hugo mod command is run for deploy
preview and branch deploy builds

- Adds docs/README with instructions for using hugo

- Updates nginx-hugo-theme module
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

None yet

2 participants