Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update AP tests and remove redundant ones #4177

Merged
merged 1 commit into from Aug 2, 2023
Merged

Update AP tests and remove redundant ones #4177

merged 1 commit into from Aug 2, 2023

Conversation

vepatel
Copy link
Contributor

@vepatel vepatel commented Aug 2, 2023

Proposed changes

  • Update security log message assertions to just keys,
  • Remove extra AP policy tests.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@vepatel vepatel requested a review from a team as a code owner August 2, 2023 11:45
@github-actions
Copy link

github-actions bot commented Aug 2, 2023

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Manifest Files

@github-actions github-actions bot added the tests Pull requests that update tests label Aug 2, 2023
@codecov
Copy link

codecov bot commented Aug 2, 2023

Codecov Report

Merging #4177 (73bdc12) into main (973317e) will decrease coverage by 0.02%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4177      +/-   ##
==========================================
- Coverage   51.91%   51.90%   -0.02%     
==========================================
  Files          59       59              
  Lines       16735    16735              
==========================================
- Hits         8688     8686       -2     
  Misses       7749     7749              
- Partials      298      300       +2     

see 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Contributor

@jjngx jjngx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@vepatel vepatel enabled auto-merge (squash) August 2, 2023 13:25
@jjngx jjngx disabled auto-merge August 2, 2023 13:48
@jjngx jjngx enabled auto-merge (squash) August 2, 2023 13:49
@jjngx jjngx disabled auto-merge August 2, 2023 13:49
@jjngx jjngx merged commit ce43fba into main Aug 2, 2023
62 checks passed
@vepatel vepatel added this to the v3.2.1 milestone Aug 16, 2023
lucacome pushed a commit that referenced this pull request Aug 17, 2023
lucacome added a commit that referenced this pull request Aug 17, 2023
(cherry picked from commit ce43fba)

Co-authored-by: Venktesh Shivam Patel <ve.patel@f5.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Pull requests that update tests
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

None yet

3 participants