Docs/upgrade using helm #4272
Merged
Docs/upgrade using helm #4272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
This commit adds a handful of changes to the Helm upgrade installation guide for NGINX Ingress Controller. It primarily changes the body of text to favour plain English over technical jargon where possible, and also recontextualises it to be less negatively-framed. It also adds some standardised formatting for NGINX products such as the use of note callouts and tabs, and reduces the inline comments to using single backticks instead of triples, which are only necessary for large blocks. The list numeration is also changed to the automatic style.
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Co-authored-by: Alan Dooley <ADubhlaoich@users.noreply.github.com> Signed-off-by: Venktesh Shivam Patel <ve.patel@f5.com>
github-actions
bot
added
the
documentation
Codecov Report
@@ Coverage Diff @@
## main #4272 +/- ##
==========================================
- Coverage 51.97% 51.95% -0.03%
==========================================
Files 59 59
Lines 16762 16762
==========================================
- Hits 8712 8708 -4
- Misses 7753 7755 +2
- Partials 297 299 +2 see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jjngx
reviewed
Aug 23, 2023
jjngx
reviewed
Aug 23, 2023
shaun-nx
approved these changes
Aug 23, 2023
haywoodsh
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Preview: https://deploy-preview-4272--nginx-kubernetes-ingress.netlify.app/nginx-ingress-controller/installation/installation-with-helm/#upgrading-without-downtime
Checklist
Before creating a PR, run through this checklist and mark each as complete.