Add imagePullSecrets to helm chart #430
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dean-Coakley
added
the
enhancement
isaachawley
approved these changes
Nov 9, 2018
pleshakov
suggested changes
Nov 9, 2018
|
Added the label "change" since the parameter |
* Updated Helm readme
Dean-Coakley
force-pushed
the
add-imagepullsecrets-helm
branch
from
8e11a86
to
459f563
Compare
pleshakov
suggested changes
Nov 12, 2018
deployments/helm-chart/templates/controller-serviceaccount.yaml
Outdated
Show resolved
Hide resolved
Co-Authored-By: Dean-Coakley <dean.s.coakley@gmail.com>
Co-Authored-By: Dean-Coakley <dean.s.coakley@gmail.com>
pleshakov
approved these changes
Nov 12, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #415
Proposed changes
imagePullSecretsto serviceaccount template of Helm chartChecklist
Before creating a PR, run through this checklist and mark each as complete.