Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prevent pip to look for dependency during install #4342

Merged
merged 4 commits into from Sep 29, 2023

Conversation

vepatel
Copy link
Contributor

@vepatel vepatel commented Sep 12, 2023

Proposed changes

  • prevent pip from looking for hashes of dependencies at the installation time

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@vepatel vepatel requested a review from a team as a code owner September 12, 2023 07:54
@github-actions github-actions bot added bug An issue reporting a potential bug tests Pull requests that update tests labels Sep 12, 2023
@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Merging #4342 (1ad9ed0) into main (8f60ab4) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4342      +/-   ##
==========================================
- Coverage   52.11%   52.08%   -0.03%     
==========================================
  Files          59       59              
  Lines       16956    16956              
==========================================
- Hits         8836     8832       -4     
- Misses       7823     7825       +2     
- Partials      297      299       +2     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@vepatel vepatel linked an issue Sep 12, 2023 that may be closed by this pull request
@lucacome
Copy link
Member

prevent pip from looking for hashes of dependencies at the installation time

Why do we want this? We don't want to use hashes?

@vepatel
Copy link
Contributor Author

vepatel commented Sep 27, 2023

@lucacome its looking for hashes of indirect dependencies during install sometimes, there's an pypi issue as well for this see the linked issue and pipeline failure for more details. We can revert this change once it's fixed.
Other option here is to use --use-deprecated=legacy-resolver
Note: pip install fails locally as well without this option.

@vepatel vepatel requested a review from jjngx September 28, 2023 11:39
@lucacome
Copy link
Member

I feel like we should figure out why it only happens sometimes before disabling it. It kind of defeats the purpose of the hashes if we don't check them...

@vepatel vepatel merged commit c993cdb into main Sep 29, 2023
62 checks passed
@vepatel vepatel deleted the fix/pip-dependency-pinning branch September 29, 2023 08:13
@vepatel
Copy link
Contributor Author

vepatel commented Sep 29, 2023

more than happy to remove hashes and go back to old way of pinning libs actually used by tests. Not sure what we can do if the issue is in pypi impementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue reporting a potential bug tests Pull requests that update tests
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

pip install is failing in CI
4 participants