New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update helm values file to move controller.serviceMonitor to prometheus.serviceMonitor #4351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shaun-nx
requested review from
lucacome,
ADubhlaoich,
haywoodsh,
jasonwilliams14 and
vepatel
September 13, 2023 20:11
github-actions
bot
added
documentation
Pull requests/issues for documentation
helm_chart
Pull requests that update the Helm Chart
labels
Sep 13, 2023
shaun-nx
changed the title
Move service monitor
Move ServiceMonitor from Sep 13, 2023
controller.serviceMonitor
to prometheus.serviceMonitor
shaun-nx
changed the title
Move ServiceMonitor from
Update helm values file to move controller.serviceMonitor to prometheus.serviceMonitor
Sep 13, 2023
controller.serviceMonitor
to prometheus.serviceMonitor
Codecov Report
@@ Coverage Diff @@
## main #4351 +/- ##
=======================================
Coverage 52.19% 52.19%
=======================================
Files 59 59
Lines 16929 16929
=======================================
Hits 8836 8836
Misses 7796 7796
Partials 297 297 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ADubhlaoich
approved these changes
Sep 14, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
vepatel
approved these changes
Sep 19, 2023
lucacome
reviewed
Sep 19, 2023
deployments/helm-chart/templates/controller-prometheus-service.yaml
Outdated
Show resolved
Hide resolved
lucacome
reviewed
Sep 19, 2023
deployments/helm-chart/templates/controller-prometheus-service.yaml
Outdated
Show resolved
Hide resolved
haywoodsh
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
documentation
Pull requests/issues for documentation
helm_chart
Pull requests that update the Helm Chart
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR moves the ServiceMonitor fields from
controller.serviceMonitor
toprometheus.serviceMonitor
in the helm values files.This is being done to bring the creation of ServiceMonitor closer to where the Prometheus Service itself is created.
Helm command used to deploy:
Checklist
Before creating a PR, run through this checklist and mark each as complete.