Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update existing prometheus documentation to include configuration options for ServiceMonitor #4414

Merged
merged 4 commits into from Sep 25, 2023

Conversation

shaun-nx
Copy link
Contributor

@shaun-nx shaun-nx commented Sep 22, 2023

Proposed changes

This PR adds to our existing prometheus document to add steps on creating a ServiceMonitor resource.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@shaun-nx shaun-nx requested review from a team as code owners September 22, 2023 09:16
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Sep 22, 2023
Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM!

@shaun-nx shaun-nx changed the base branch from main to release-3.2 September 22, 2023 12:58
@shaun-nx shaun-nx changed the base branch from release-3.2 to main September 22, 2023 12:59
@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Merging #4414 (12c01f1) into main (abe4950) will decrease coverage by 0.03%.
The diff coverage is n/a.

❗ Current head 12c01f1 differs from pull request most recent head 90da571. Consider uploading reports for the commit 90da571 to get more accurate results

@@            Coverage Diff             @@
##             main    #4414      +/-   ##
==========================================
- Coverage   52.11%   52.08%   -0.03%     
==========================================
  Files          59       59              
  Lines       16956    16956              
==========================================
- Hits         8836     8832       -4     
- Misses       7823     7825       +2     
- Partials      297      299       +2     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@shaun-nx shaun-nx merged commit 3363efe into main Sep 25, 2023
63 checks passed
@shaun-nx shaun-nx deleted the docs/prometheusWithServiceMonitor branch September 25, 2023 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

Add documentation to demonstrate exposing Prometheus Metrics from IC using a ServiceMonitor resource
3 participants