Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update helm readme and docs #4474

Merged
merged 6 commits into from Oct 5, 2023
Merged

Update helm readme and docs #4474

merged 6 commits into from Oct 5, 2023

Conversation

vepatel
Copy link
Contributor

@vepatel vepatel commented Oct 5, 2023

Proposed changes

  • Update helm docs with sections and values overwritten by release script

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@vepatel vepatel requested review from a team as code owners October 5, 2023 10:01
@github-actions github-actions bot added documentation Pull requests/issues for documentation helm_chart Pull requests that update the Helm Chart labels Oct 5, 2023
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #4474 (5eac9dc) into main (2e19db8) will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4474      +/-   ##
==========================================
- Coverage   51.97%   51.95%   -0.03%     
==========================================
  Files          59       59              
  Lines       16956    16956              
==========================================
- Hits         8813     8809       -4     
- Misses       7848     7850       +2     
- Partials      295      297       +2     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@vepatel vepatel linked an issue Oct 5, 2023 that may be closed by this pull request
charts/nginx-ingress/README.md Show resolved Hide resolved
@lucacome lucacome dismissed their stale review October 5, 2023 14:52

dismissing

@vepatel vepatel merged commit ddcdb27 into main Oct 5, 2023
62 checks passed
@vepatel vepatel deleted the docs/fix-helm-table branch October 5, 2023 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation helm_chart Pull requests that update the Helm Chart
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

Fix helm documentation for main and release-3.3
6 participants