Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update python version and test #4500

Merged
merged 2 commits into from Oct 11, 2023
Merged

Update python version and test #4500

merged 2 commits into from Oct 11, 2023

Conversation

vepatel
Copy link
Contributor

@vepatel vepatel commented Oct 11, 2023 •
edited

Proposed changes

  • Update python version in test dockerfile,
  • Update test to work with new version as ssl.wrap_socket is now removed in 3.12.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@vepatel vepatel requested a review from a team as a code owner October 11, 2023 13:26
@github-actions github-actions bot added the tests Pull requests that update tests label Oct 11, 2023
@vepatel vepatel linked an issue Oct 11, 2023 that may be closed by this pull request
Update TS loadbalancer test to work with python 3.12 #4499
Closed
@vepatel vepatel enabled auto-merge (squash) October 11, 2023 14:46
@vepatel vepatel merged commit 801746a into main Oct 11, 2023
60 checks passed
@vepatel vepatel deleted the tests/update-python-version-and-tests branch October 11, 2023 16:19
lucacome pushed a commit that referenced this pull request Oct 16, 2023
@vepatel @lucacome
Update python version (#4500)
5b9ab93
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjngx jjngx jjngx approved these changes

@shaun-nx shaun-nx shaun-nx approved these changes

@lucacome lucacome Awaiting requested review from lucacome

Assignees
No one assigned
Labels
tests Pull requests that update tests
Projects
NGINX Ingress Controller
Status: Done 🚀
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update TS loadbalancer test to work with python 3.12
3 participants
@vepatel @jjngx @shaun-nx