Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove redundant newlines in generated v1 configuration #4699

Merged
merged 7 commits into from Nov 25, 2023

Conversation

oseoin
Copy link
Contributor

@oseoin oseoin commented Nov 23, 2023

Proposed changes

Remove unneeded newlines in v1 configuration to improve readability of output configuration. These changes had the following impact for examples/ingress-resources/complete-example for v1 and examples/custom-resources/basic-auth for v2:

Version File Lines before Lines after % reduction
v1 nginx.conf 155 116 ~25%
v1 default-cafe-ingress.conf 139 82 ~41%
v2 nginx.conf 155 116 ~25%
v2 vs_default_cafe.conf 266 84 ~68%

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

Copy link

codecov bot commented Nov 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (046ef03) 51.93% compared to head (75d2bf3) 51.90%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4699      +/-   ##
==========================================
- Coverage   51.93%   51.90%   -0.04%     
==========================================
  Files          59       59              
  Lines       16973    16973              
==========================================
- Hits         8815     8809       -6     
- Misses       7860     7864       +4     
- Partials      298      300       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oseoin oseoin marked this pull request as ready for review November 23, 2023 12:13
@oseoin oseoin requested a review from a team as a code owner November 23, 2023 12:13
Copy link
Contributor

@jjngx jjngx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@jjngx jjngx merged commit 40979b3 into main Nov 25, 2023
62 checks passed
@jjngx jjngx deleted the tmpl-newline-cleanup branch November 25, 2023 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants