Rewrite NGINX App Protect WAF Integration Section #4726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit rewrites the installation document for NGINX App Protect WAF to match the format posited in the prior NGINX App Protect DOS rewrite. As part of the changes, a snippet of text indicating the deployment options for NGINX Ingress Controller was turned into an include.
github-actions
bot
added
the
documentation
ADubhlaoich
changed the title
jjngx
approved these changes
Nov 30, 2023
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4726 +/- ##
=======================================
Coverage 52.01% 52.01%
=======================================
Files 60 60
Lines 17313 17313
=======================================
Hits 9005 9005
Misses 7995 7995
Partials 313 313 ☔ View full report in Codecov by Sentry. |
This commit adds a new include file for custom resources, and subsequently adds it to the relevant App Protect WAF/DoS documentation. A few documentation improvements arej also included to rephrase sections of the configuration document for conciseness and clarity.
for more information, see https://pre-commit.ci
docs/content/installation/installing-nic/installation-with-manifests.md
Outdated
Show resolved
Hide resolved
Jcahilltorre
approved these changes
Dec 13, 2023
ADubhlaoich
commented
Dec 13, 2023
docs/content/installation/installing-nic/installation-with-manifests.md
Outdated
Show resolved
Hide resolved
…ifests.md Signed-off-by: Alan Dooley <ADubhlaoich@users.noreply.github.com>
ADubhlaoich
added a commit
to ADubhlaoich/nic-doc-work
that referenced
this pull request
Dec 27, 2023
This commit rewrites the installation document for NGINX App Protect WAF to match the format posited in the prior NGINX App Protect DOS rewrite. As part of the changes, a snippet of text indicating the deployment options for NGINX Ingress Controller was turned into an include. This commit adds a new include file for custom resources, and subsequently adds it to the relevant App Protect WAF/DoS documentation. A few documentation improvements are also included to rephrase sections of the configuration document for conciseness and clarity.
ADubhlaoich
added a commit
to ADubhlaoich/nic-doc-work
that referenced
this pull request
Dec 27, 2023
This commit rewrites the installation document for NGINX App Protect WAF to match the format posited in the prior NGINX App Protect DOS rewrite. As part of the changes, a snippet of text indicating the deployment options for NGINX Ingress Controller was turned into an include. This commit adds a new include file for custom resources, and subsequently adds it to the relevant App Protect WAF/DoS documentation. A few documentation improvements are also included to rephrase sections of the configuration document for conciseness and clarity.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR rewrites the integration section for NGINX App Protect WAF, finishing the first set of major IA changes for the NGINX Ingress Controller docset. Much of the format and detail comes from the precedent set by work for the DOS section.
Rewrite NGINX App Protect WAF Installation, add deployment include
This commit rewrites the installation document for NGINX App Protect WAF to match the format posited in the prior NGINX App Protect DOS rewrite. As part of the changes, a snippet of text indicating the deployment options for NGINX Ingress Controller was turned into an include.
Checklist
Before creating a PR, run through this checklist and mark each as complete.