Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add docker fallback for hugo and markdownlint #4747

Merged
merged 2 commits into from Dec 5, 2023

Conversation

nginx-jack
Copy link
Contributor

@nginx-jack nginx-jack commented Dec 5, 2023

Proposed changes

Adds a docker fallback for hugo and markdownlint. The goal is to make it possible to contribute to documentation without needing to install additional tooling (expect docker!).

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes NA
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@nginx-jack nginx-jack requested review from a team as code owners December 5, 2023 10:47
Copy link

codecov bot commented Dec 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7ae5a19) 52.09% compared to head (70bf420) 52.09%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4747   +/-   ##
=======================================
  Coverage   52.09%   52.09%           
=======================================
  Files          59       59           
  Lines       17033    17033           
=======================================
  Hits         8873     8873           
  Misses       7862     7862           
  Partials      298      298           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but you should be aware that NGINX Ingress Controller does not use conventional commits.

@vepatel vepatel merged commit c7ccdc9 into nginxinc:main Dec 5, 2023
65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

None yet

5 participants