Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazy loading OSS #4788

Merged
merged 7 commits into from Dec 13, 2023
Merged

Lazy loading OSS #4788

merged 7 commits into from Dec 13, 2023

Conversation

oseoin
Copy link
Contributor

@oseoin oseoin commented Dec 12, 2023

Proposed changes

Update changes in 4764 to remove incorrect Plus requirement for lazy loading of certificates.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@github-actions github-actions bot added documentation Pull requests/issues for documentation tests Pull requests that update tests labels Dec 12, 2023
Copy link

codecov bot commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f95be93) 52.00% compared to head (7fc73db) 52.01%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4788      +/-   ##
==========================================
+ Coverage   52.00%   52.01%   +0.01%     
==========================================
  Files          60       60              
  Lines       17317    17313       -4     
==========================================
  Hits         9005     9005              
+ Misses       7999     7995       -4     
  Partials      313      313              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@oseoin oseoin marked this pull request as ready for review December 12, 2023 21:26
@oseoin oseoin requested review from a team as code owners December 12, 2023 21:26
@oseoin oseoin changed the title Lazy loading oss Lazy loading OSS Dec 12, 2023
@jjngx jjngx requested a review from a team December 12, 2023 21:40
@haywoodsh
Copy link
Contributor

haywoodsh commented Dec 13, 2023

Hi @oseoin, I think the phrasing in the helm chart docs has to be changed as well.
https://github.com/nginxinc/kubernetes-ingress/blob/main/charts/nginx-ingress/README.md?plain=1#L461

|`controller.enableSSLDynamicReload` | Enable lazy loading for SSL Certificates for NGINX Plus. | true |

https://github.com/nginxinc/kubernetes-ingress/blob/main/charts/nginx-ingress/values.yaml#L466

 ## Enable dynamic reloading of certificates for NGINX Plus

Also, docs missing
https://github.com/nginxinc/kubernetes-ingress/blob/main/docs/content/installation/installing-nic/installation-with-helm.md

@github-actions github-actions bot added the helm_chart Pull requests that update the Helm Chart label Dec 13, 2023
@oseoin oseoin merged commit 6fee254 into main Dec 13, 2023
68 checks passed
@oseoin oseoin deleted the lazy-loading-oss branch December 13, 2023 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation helm_chart Pull requests that update the Helm Chart tests Pull requests that update tests
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

None yet

5 participants