Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vs markers #4793

Merged
merged 17 commits into from Dec 14, 2023
Merged

Vs markers #4793

merged 17 commits into from Dec 14, 2023

Conversation

pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Dec 13, 2023

Proposed changes

Split VirtualServer tests as they were the longest running test job

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 self-assigned this Dec 13, 2023
@github-actions github-actions bot added the tests Pull requests that update tests label Dec 13, 2023
Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b84e64f) 52.01% compared to head (270b5cc) 52.01%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4793   +/-   ##
=======================================
  Coverage   52.01%   52.01%           
=======================================
  Files          60       60           
  Lines       17313    17313           
=======================================
  Hits         9005     9005           
  Misses       7995     7995           
  Partials      313      313           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pdabelf5 pdabelf5 marked this pull request as ready for review December 13, 2023 13:28
@pdabelf5 pdabelf5 requested a review from a team as a code owner December 13, 2023 13:28
@pdabelf5 pdabelf5 added the github_actions Pull requests that update Github_actions code label Dec 13, 2023
@oseoin oseoin merged commit 4a9832a into main Dec 14, 2023
76 checks passed
@oseoin oseoin deleted the vs-markers branch December 14, 2023 12:03
oseoin pushed a commit that referenced this pull request Dec 15, 2023
split test matrix for vs and policies to reduce pipeline duration
oseoin added a commit that referenced this pull request Dec 15, 2023
split test matrix for vs and policies to reduce pipeline duration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update Github_actions code tests Pull requests that update tests
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

None yet

4 participants