Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base image hash #4871

Merged
merged 4 commits into from Jan 15, 2024
Merged

Base image hash #4871

merged 4 commits into from Jan 15, 2024

Conversation

pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Jan 5, 2024

Proposed changes

Add SHA has to all docker base images to address security scan issues

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 self-assigned this Jan 5, 2024
@pdabelf5 pdabelf5 requested a review from a team as a code owner January 5, 2024 15:39
@pdabelf5 pdabelf5 linked an issue Jan 5, 2024 that may be closed by this pull request
2 tasks
@github-actions github-actions bot added the tests Pull requests that update tests label Jan 5, 2024
Copy link

codecov bot commented Jan 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ed590bd) 52.28% compared to head (8f9668a) 52.28%.
Report is 2 commits behind head on main.

❗ Current head 8f9668a differs from pull request most recent head 1ef2555. Consider uploading reports for the commit 1ef2555 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4871   +/-   ##
=======================================
  Coverage   52.28%   52.28%           
=======================================
  Files          60       60           
  Lines       17501    17501           
=======================================
  Hits         9151     9151           
  Misses       8020     8020           
  Partials      330      330           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pdabelf5 pdabelf5 merged commit fa0f2e2 into main Jan 15, 2024
79 checks passed
@pdabelf5 pdabelf5 deleted the base-image-hash branch January 15, 2024 11:38
pdabelf5 added a commit that referenced this pull request Jan 15, 2024
add docker image sha to dockerfile
pdabelf5 added a commit that referenced this pull request Jan 15, 2024
add docker image sha to dockerfile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Pull requests that update tests
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

Fix code scanning alert - Pinned-Dependencies
4 participants