Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure latest tag is used for GIT_TAG #4878

Merged
merged 3 commits into from Jan 9, 2024
Merged

ensure latest tag is used for GIT_TAG #4878

merged 3 commits into from Jan 9, 2024

Conversation

pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Jan 9, 2024

Proposed changes

Update to make sure the version variable is the latest tag

$ make build
Docker version 24.0.6, build ed223bc
go version go1.21.4 darwin/arm64
CGO_ENABLED=0 GOOS=linux GOARCH=amd64 go build -trimpath -ldflags "-s -w -X main.version=v3.4.0-SNAPSHOT" -o nginx-ingress github.com/nginxinc/kubernetes-ingress/cmd/nginx-ingress

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 requested a review from a team as a code owner January 9, 2024 09:39
@pdabelf5 pdabelf5 merged commit 6574d10 into main Jan 9, 2024
77 checks passed
@pdabelf5 pdabelf5 deleted the makefile-version-tag branch January 9, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

None yet

4 participants