Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put configuration of ldflags closer to top of makefile #4880

Merged
merged 4 commits into from Jan 9, 2024

Conversation

shaun-nx
Copy link
Contributor

@shaun-nx shaun-nx commented Jan 9, 2024

Proposed changes

ldflags provide us with a means to inject values at build time.
We currently use this to inject the version of NIC. Overtime we can expand this to add more data as we see fit.

This change simply makes adding additional ldflags more user friendly by making the configuration more obvious and easier to expand.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@shaun-nx shaun-nx requested a review from a team as a code owner January 9, 2024 10:25
Copy link

codecov bot commented Jan 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (38a03fa) 52.11% compared to head (d8a5843) 52.11%.
Report is 6 commits behind head on main.

❗ Current head d8a5843 differs from pull request most recent head 053ac92. Consider uploading reports for the commit 053ac92 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4880   +/-   ##
=======================================
  Coverage   52.11%   52.11%           
=======================================
  Files          60       60           
  Lines       17394    17394           
=======================================
  Hits         9065     9065           
  Misses       8011     8011           
  Partials      318      318           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shaun-nx shaun-nx merged commit 0b0c658 into main Jan 9, 2024
77 checks passed
@shaun-nx shaun-nx deleted the makefile-ldflags branch January 9, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

None yet

5 participants