Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add alpine-plus-nap-waf-fips to NAP smoke test #4913

Merged
merged 2 commits into from Jan 15, 2024
Merged

add alpine-plus-nap-waf-fips to NAP smoke test #4913

merged 2 commits into from Jan 15, 2024

Conversation

pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Jan 12, 2024 •
edited

Proposed changes

Use FIPS NAP image for some of the APP Protect tests

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 marked this pull request as ready for review January 12, 2024 16:42
@pdabelf5 pdabelf5 requested a review from a team as a code owner January 12, 2024 16:42
@pdabelf5 pdabelf5 self-assigned this Jan 15, 2024
@pdabelf5 pdabelf5 merged commit fa9448a into main Jan 15, 2024
79 checks passed
@pdabelf5 pdabelf5 deleted the appprotect-tests branch January 15, 2024 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vepatel vepatel vepatel approved these changes

@jjngx jjngx jjngx approved these changes

Assignees

@pdabelf5 pdabelf5

Labels
None yet
Projects
NGINX Ingress Controller
Status: Done 🚀
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@pdabelf5 @vepatel @jjngx @oseoin