Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split version update script #4961

Merged
merged 6 commits into from Jan 23, 2024
Merged

Split version update script #4961

merged 6 commits into from Jan 23, 2024

Conversation

pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Jan 23, 2024

Proposed changes

  • Escape release & helm version regexes to avoid . being treated as part of the regex.
  • Make updating release notes a seperate script in preparation for further enhancements to the process.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 requested a review from a team as a code owner January 23, 2024 12:39
Copy link

codecov bot commented Jan 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d6f5fe3) 52.28% compared to head (826d13b) 52.28%.
Report is 4 commits behind head on main.

❗ Current head 826d13b differs from pull request most recent head 57b6ae4. Consider uploading reports for the commit 57b6ae4 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4961   +/-   ##
=======================================
  Coverage   52.28%   52.28%           
=======================================
  Files          60       60           
  Lines       17501    17501           
=======================================
  Hits         9151     9151           
  Misses       8020     8020           
  Partials      330      330           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pdabelf5 pdabelf5 merged commit 96b2ede into main Jan 23, 2024
79 checks passed
@pdabelf5 pdabelf5 deleted the update-version branch January 23, 2024 18:09
pdabelf5 added a commit that referenced this pull request Feb 14, 2024
@pdabelf5 pdabelf5 mentioned this pull request Feb 14, 2024
6 tasks
pdabelf5 added a commit that referenced this pull request Feb 14, 2024
* Split version update script (#4961)

* Bump nginx from `156d75f` to `f2802c2` in /build (#5072)

* Bump redhat/ubi8 from `23d8dfd` to `627867e` in /build (#5073)

* Bump opentracing/nginx-opentracing from `2e0268d` to `2217e9f` in /build (#5074)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

None yet

3 participants