Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

switch to using static file for version #4973

Merged
merged 2 commits into from Jan 25, 2024
Merged

switch to using static file for version #4973

merged 2 commits into from Jan 25, 2024

Conversation

pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Jan 24, 2024

Proposed changes

Ensure versions are correct for immutable binaries & container images.
This change will make edge container images contain a nginx-ingress binary that will advertise itself as the next up & coming release, rather than edge.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 requested a review from a team as a code owner January 24, 2024 11:33
Copy link

codecov bot commented Jan 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e02f2bd) 52.32% compared to head (78816fb) 52.29%.
Report is 2 commits behind head on main.

❗ Current head 78816fb differs from pull request most recent head ac6c17e. Consider uploading reports for the commit ac6c17e to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4973      +/-   ##
==========================================
- Coverage   52.32%   52.29%   -0.03%     
==========================================
  Files          60       60              
  Lines       17501    17501              
==========================================
- Hits         9157     9153       -4     
- Misses       8016     8018       +2     
- Partials      328      330       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pdabelf5 pdabelf5 linked an issue Jan 24, 2024 that may be closed by this pull request
@pdabelf5 pdabelf5 self-assigned this Jan 24, 2024
@pdabelf5 pdabelf5 added the github_actions Pull requests that update Github_actions code label Jan 24, 2024
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@pdabelf5 pdabelf5 merged commit 515a7e3 into main Jan 25, 2024
76 checks passed
@pdabelf5 pdabelf5 deleted the goreleaser-version branch January 25, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update Github_actions code
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

update goreleaser to use environment variable for version
5 participants