Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix minor documentation issues based on drift and feedback #5011

Merged
merged 10 commits into from Feb 2, 2024

Conversation

ADubhlaoich
Copy link
Contributor

@ADubhlaoich ADubhlaoich commented Jan 30, 2024

Proposed changes

This pull request re-adds some documentation changes from late last year that were lost during some major refactoring.

It also addresses some feedback submitted through the form that was missed during the interim period as a result of some automation disconnecting, which meant the primary place the feedback is viewed received no updates.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

This commit re-adds some documentation changes from late last year that
were lost during some major refactoring. It also addresses some feedback
submitted through the form that was missed during the interim period
since as a result of some automation disconnecting, which meant the
primary place the feedback is viewed received no updates.
@ADubhlaoich ADubhlaoich self-assigned this Jan 30, 2024
@ADubhlaoich ADubhlaoich requested review from a team as code owners January 30, 2024 17:26
Copy link

netlify bot commented Jan 30, 2024

👷 Deploy request for nginx-kubernetes-ingress pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit cb8b34f

@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Jan 30, 2024
@ADubhlaoich ADubhlaoich enabled auto-merge (squash) January 30, 2024 17:26
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8a2c9a9) 52.32% compared to head (175b394) 52.32%.
Report is 2 commits behind head on main.

❗ Current head 175b394 differs from pull request most recent head cb8b34f. Consider uploading reports for the commit cb8b34f to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5011   +/-   ##
=======================================
  Coverage   52.32%   52.32%           
=======================================
  Files          61       61           
  Lines       17502    17502           
=======================================
  Hits         9158     9158           
  Misses       8015     8015           
  Partials      329      329           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@vepatel vepatel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pending @j1m-ryan's comment resolution.

ADubhlaoich and others added 2 commits February 2, 2024 10:34
Co-authored-by: Jim Ryan <j.ryan@f5.com>
Signed-off-by: Alan Dooley <github@adubhlaoi.ch>
@ADubhlaoich ADubhlaoich merged commit 3ebaa57 into nginxinc:main Feb 2, 2024
44 of 48 checks passed
@ADubhlaoich ADubhlaoich deleted the docs/misc-feedback-updates branch February 2, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Pull requests/issues for documentation
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

None yet

3 participants