Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix template file spacing for ssl_protocols directive #5020

Merged
merged 3 commits into from Feb 1, 2024

Conversation

j1m-ryan
Copy link
Member

Proposed changes

Before

map $http_upgrade $vs_connection_header {
        default upgrade;
        ''      $default_connection_header;
}ssl_protocols TLSv1.2 TLSv1.3;

After

map $http_upgrade $vs_connection_header {
        default upgrade;
        ''      $default_connection_header;
}
ssl_protocols TLSv1.2 TLSv1.3;

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@j1m-ryan j1m-ryan requested a review from a team as a code owner January 31, 2024 17:32
Copy link

netlify bot commented Jan 31, 2024

👷 Deploy request for nginx-kubernetes-ingress pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 9aeb786

@github-actions github-actions bot added the bug An issue reporting a potential bug label Jan 31, 2024
Copy link

codecov bot commented Jan 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (81a2233) 52.32% compared to head (5ccbfbb) 52.35%.
Report is 3 commits behind head on main.

❗ Current head 5ccbfbb differs from pull request most recent head 9aeb786. Consider uploading reports for the commit 9aeb786 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5020      +/-   ##
==========================================
+ Coverage   52.32%   52.35%   +0.03%     
==========================================
  Files          61       61              
  Lines       17502    17502              
==========================================
+ Hits         9158     9164       +6     
+ Misses       8015     8011       -4     
+ Partials      329      327       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@j1m-ryan j1m-ryan enabled auto-merge (squash) February 1, 2024 09:12
@j1m-ryan j1m-ryan merged commit 7f0efa4 into nginxinc:main Feb 1, 2024
48 of 51 checks passed
j1m-ryan added a commit to j1m-ryan/kubernetes-ingress that referenced this pull request Feb 9, 2024
j1m-ryan added a commit to j1m-ryan/kubernetes-ingress that referenced this pull request Feb 9, 2024
j1m-ryan added a commit that referenced this pull request Feb 9, 2024
…5020) (#5060)

Fix template file spacing for `ssl_protocols` directive (#5020)

template file space
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug An issue reporting a potential bug
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

None yet

4 participants