Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use pre-built base images #5061

Merged
merged 2 commits into from Feb 19, 2024
Merged

use pre-built base images #5061

merged 2 commits into from Feb 19, 2024

Conversation

pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Feb 9, 2024

Proposed changes

Use pre-built base images in CI workflow on non-forked workflows. Rebuild base images if they do not already exist.

Also, avoid rebuilding images for Trivy scan, use the image built in the workflow.

Testing

Tested forked workflow, users without access to secrets still use cached layers for plus image builds
https://github.com/nginxinc/kubernetes-ingress/actions/runs/7884962378

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 force-pushed the base-image-use branch 2 times, most recently from 924e15d to acc2be6 Compare February 12, 2024 11:40
@github-actions github-actions bot added the tests Pull requests that update tests label Feb 13, 2024
@github-actions github-actions bot removed the tests Pull requests that update tests label Feb 13, 2024
@pdabelf5 pdabelf5 marked this pull request as ready for review February 13, 2024 11:11
@pdabelf5 pdabelf5 requested a review from a team as a code owner February 13, 2024 11:11
@pdabelf5 pdabelf5 changed the title pre-built base image use use pre-built base images Feb 13, 2024
@pdabelf5 pdabelf5 linked an issue Feb 13, 2024 that may be closed by this pull request
@pdabelf5 pdabelf5 merged commit ffdcf0f into main Feb 19, 2024
77 checks passed
@pdabelf5 pdabelf5 deleted the base-image-use branch February 19, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

Base images for each OS flavour
3 participants