Fixed validation for VSR exact & regex subroutes (#4744) #5079
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Fixed validation for VSR exact & regex subroutes Since a VSR may only contain a single subroute when using exact or regex matching skipping route validation here is incorrect. Correctly configured VSRs for regex or exact will be validated (and terminate) earlier in function, ie. where VS path is regex + only 1 subroute + subroute syntax check passes. * Added Unit Tests * Fix validation Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com> * Add unit tests and update docs Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com> * Adjusted Unit test messages. --------- Signed-off-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com> Co-authored-by: Haywood Shannon <5781935+haywoodsh@users.noreply.github.com> Co-authored-by: Venktesh Shivam Patel <ve.patel@f5.com>
github-actions
bot
added
the
documentation
vepatel
approved these changes
Feb 13, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release-3.4 #5079 +/- ##
===============================================
+ Coverage 52.10% 52.14% +0.03%
===============================================
Files 60 60
Lines 17368 17368
===============================================
+ Hits 9050 9056 +6
+ Misses 8002 7996 -6
Partials 316 316 ☔ View full report in Codecov by Sentry. |
haywoodsh
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since a VSR may only contain a single subroute when using exact or regex matching skipping route validation here is incorrect.
Correctly configured VSRs for regex or exact will be validated (and terminate) earlier in function, ie. where VS path is regex + only 1 subroute + subroute syntax check passes.