Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow each image to have its own cache #5080

Merged
merged 3 commits into from Feb 13, 2024
Merged

allow each image to have its own cache #5080

merged 3 commits into from Feb 13, 2024

Conversation

pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Feb 13, 2024

Proposed changes

Reading https://docs.docker.com/build/cache/backends/gha/#scope describes needing to change the scope when caching multiple docker builds to prevent the last image being cached as the only one in the cache.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 requested a review from a team as a code owner February 13, 2024 10:47
@pdabelf5 pdabelf5 merged commit 9e33e5a into main Feb 13, 2024
76 checks passed
@pdabelf5 pdabelf5 deleted the base-image-caching branch February 13, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

None yet

4 participants