Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect count of VirtualServer, VirtualServerRoute and TransportServer resources #5095

Merged
merged 22 commits into from Feb 20, 2024

Conversation

shaun-nx
Copy link
Contributor

@shaun-nx shaun-nx commented Feb 14, 2024

Proposed changes

This change updates the base telemetry job to collect a count of VirtualServer and TransportServer resources that are observed by the Ingress Controller.

Closes #4902 and #4903

Testing

Test cases in collector.go cover scenarios where:

  1. Resources in a watched namespace is counted
  2. Resources not in a watched namespace is not counted
  3. Resources deployed across multiple namespaces are counted if those namespaces are watched

Additional changes

Renamed telemetry.go to collector.go
Moved code related to the DiscardExporter out of collector.go and into exporter.go

Note: Tests in collector_test.go cover calls to the Export function in exporter.go

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@shaun-nx shaun-nx changed the title Telemety/vs and ts counts Collect count of VirtualServer and TransportServer resrouces Feb 14, 2024
@shaun-nx shaun-nx linked an issue Feb 14, 2024 that may be closed by this pull request
@shaun-nx shaun-nx marked this pull request as ready for review February 16, 2024 12:19
@shaun-nx shaun-nx requested a review from a team as a code owner February 16, 2024 12:19
internal/k8s/controller.go Outdated Show resolved Hide resolved
internal/k8s/controller.go Outdated Show resolved Hide resolved
@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Feb 16, 2024
@shaun-nx shaun-nx requested a review from jjngx February 19, 2024 17:04
@shaun-nx shaun-nx changed the title Collect count of VirtualServer and TransportServer resrouces Collect count of VirtualServer, VirtualServerRoute and TransportServer resources Feb 20, 2024
@pdabelf5 pdabelf5 removed the dependencies Pull requests that update a dependency file label Feb 20, 2024
@shaun-nx shaun-nx requested a review from jjngx February 20, 2024 11:53
@github-actions github-actions bot added the dependencies Pull requests that update a dependency file label Feb 20, 2024
@shaun-nx shaun-nx merged commit 1eea001 into main Feb 20, 2024
53 checks passed
@shaun-nx shaun-nx deleted the telemety/vs-and-ts-counts branch February 20, 2024 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

Count of TransportServers in watched namespaces Count of VirtualServers in watched namespaces
4 participants