Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor child process configuration #5124

Merged
merged 3 commits into from Feb 19, 2024
Merged

refactor child process configuration #5124

merged 3 commits into from Feb 19, 2024

Conversation

oseoin
Copy link
Contributor

@oseoin oseoin commented Feb 19, 2024

Proposed changes

Small refactor of how child processes are started/stopped ahead of adding agent process management.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@oseoin oseoin marked this pull request as ready for review February 19, 2024 17:11
@oseoin oseoin requested a review from a team as a code owner February 19, 2024 17:11
@oseoin oseoin merged commit 6e89b15 into main Feb 19, 2024
77 checks passed
@oseoin oseoin deleted the child-process-refactor branch February 19, 2024 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

None yet

4 participants