Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor base image generation on main CI flow #5187

Merged
merged 1 commit into from Feb 29, 2024
Merged

Conversation

pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Feb 29, 2024

Proposed changes

Rebuilding the base images was failing if it didn't already exist.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 requested a review from a team as a code owner February 29, 2024 15:13
@pdabelf5 pdabelf5 force-pushed the rebuild-base-images branch 4 times, most recently from a8c0583 to 0f3c9cc Compare February 29, 2024 16:32
@pdabelf5 pdabelf5 merged commit 2c30dc3 into main Feb 29, 2024
77 checks passed
@pdabelf5 pdabelf5 deleted the rebuild-base-images branch February 29, 2024 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

None yet

3 participants