Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ExternalDNS controller should handle errors registering the EventHandler #5190

Merged
merged 3 commits into from Mar 8, 2024
Merged

ExternalDNS controller should handle errors registering the EventHandler #5190

merged 3 commits into from Mar 8, 2024

Conversation

pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Feb 29, 2024 •
edited

Proposed changes

ExternalDNS controller should handle errors registering the EventHandler

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 requested a review from a team as a code owner February 29, 2024 17:37
jjngx
jjngx approved these changes Mar 5, 2024
View reviewed changes
Copy link
Contributor

@jjngx jjngx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@pdabelf5 pdabelf5 merged commit 455bcdf into main Mar 8, 2024
77 checks passed
@pdabelf5 pdabelf5 deleted the external-dns-handle-errors branch March 8, 2024 15:43
@pdabelf5 pdabelf5 mentioned this pull request Mar 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oseoin oseoin oseoin approved these changes

@jjngx jjngx jjngx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
NGINX Ingress Controller
Status: Done 🚀
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pdabelf5 @oseoin @jjngx