Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for building images in fork workflow #5225

Merged
merged 2 commits into from Mar 8, 2024
Merged

Conversation

pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Mar 8, 2024

Proposed changes

Images were not being built in the fork workflow.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork

@pdabelf5 pdabelf5 requested a review from a team as a code owner March 8, 2024 15:32
@pdabelf5 pdabelf5 force-pushed the forked-workflow-image-build branch from dd26f70 to 2a58e6d Compare March 8, 2024 15:47
@pdabelf5 pdabelf5 force-pushed the forked-workflow-image-build branch from 2a58e6d to c75d3b6 Compare March 8, 2024 16:21
@pdabelf5 pdabelf5 merged commit 631beae into main Mar 8, 2024
77 checks passed
@pdabelf5 pdabelf5 deleted the forked-workflow-image-build branch March 8, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done 🚀
Development

Successfully merging this pull request may close these issues.

None yet

4 participants